Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codecov token from script #176

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

zyiou
Copy link
Contributor

@zyiou zyiou commented Apr 21, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #176 (ea6bbf6) into release-0.5.0 (d611dbf) will increase coverage by 0.19%.
The diff coverage is n/a.

❗ Current head ea6bbf6 differs from pull request most recent head 8e839da. Consider uploading reports for the commit 8e839da to get more accurate results
Impacted file tree graph

@@                Coverage Diff                @@
##           release-0.5.0     #176      +/-   ##
=================================================
+ Coverage          78.68%   78.88%   +0.19%     
=================================================
  Files                 16       16              
  Lines               2008     2008              
=================================================
+ Hits                1580     1584       +4     
+ Misses               284      280       -4     
  Partials             144      144              
Flag Coverage Δ
integration-tests 63.12% <ø> (-0.92%) ⬇️
unit-tests 78.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/intermediate/aggregate.go 74.37% <0.00%> (+1.25%) ⬆️

@zyiou zyiou marked this pull request as ready for review April 21, 2021 03:52
@zyiou zyiou requested a review from srikartati April 21, 2021 03:59
@zyiou zyiou changed the base branch from main to release-0.5.0 April 21, 2021 04:07
Copy link
Contributor

@srikartati srikartati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious. What was its purpose when it was added?

@zyiou
Copy link
Contributor Author

zyiou commented Apr 21, 2021

Just curious. What was its purpose when it was added?

When creating this yaml file, I thought this token was required for uploading coverage report, so I copied the token from my codecov account.

@zyiou zyiou merged commit 8cc18af into vmware:release-0.5.0 Apr 21, 2021
zyiou added a commit to zyiou/go-ipfix that referenced this pull request Apr 30, 2021
zyiou added a commit to zyiou/go-ipfix that referenced this pull request Apr 30, 2021
zyiou added a commit to zyiou/go-ipfix that referenced this pull request May 10, 2021
zyiou added a commit to zyiou/go-ipfix that referenced this pull request May 10, 2021
zyiou added a commit that referenced this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants